linux-kernel - Re: [PATCH -rt] rt-slab: fix cpu inconsistency case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0803201519160.21990@gandalf.stny.rr.com>
Date:	Thu, 20 Mar 2008 15:32:35 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH -rt] rt-slab: fix cpu inconsistency case


Hi Hiroshi,

Thanks for looking into it. I'll take a deeper look at it later, but
first I have a few nitpicks with the patch.

On Thu, 20 Mar 2008, Hiroshi Shimamoto wrote:
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> ---
>  mm/slab.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 4bf6ca8..7beb378 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -138,8 +138,8 @@
>   *
>   * (On PREEMPT_RT, these are NOPs, but we have to drop/get the irq locks.)
>   */
> -# define slab_irq_disable_nort()	local_irq_disable()
> -# define slab_irq_enable_nort()		local_irq_enable()
> +# define slab_irq_disable_nort(cpu)	slab_irq_disable(cpu)
> +# define slab_irq_enable_nort(cpu)	slab_irq_enable(cpu)

This is the !PREEMPT_RT version. It should stay as is (with the
exception of ignoring the "cpu" variable. [ (void)cpu; ? ]

#define slab_irq_disable_nort(cpu) \
	do { \
		(void)cpu;  \
		local_irq_disable(); \
	} while(0)


>  # define slab_irq_disable_rt(flags)	do { (void)(flags); } while (0)
>  # define slab_irq_enable_rt(flags)	do { (void)(flags); } while (0)
>  # define slab_spin_lock_irq(lock, cpu) \
> @@ -160,8 +160,8 @@ DEFINE_PER_CPU_LOCKED(int, slab_irq_locks) = { 0, };
>  	do { slab_irq_enable(cpu); (void) (flags); } while (0)
>  # define slab_irq_disable_rt(cpu)	slab_irq_disable(cpu)
>  # define slab_irq_enable_rt(cpu)	slab_irq_enable(cpu)
> -# define slab_irq_disable_nort()	do { } while (0)
> -# define slab_irq_enable_nort()		do { } while (0)
> +# define slab_irq_disable_nort(cpu)	do { } while (0)
> +# define slab_irq_enable_nort(cpu)	do { } while (0)

And these are the PREEMPT_RT version. So basically, this patch is a nop
for PREEMPT_RT. I doubt it will solve your bug ;-)


-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/