lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Mar 2008 22:52:27 +0000 From: Adrian McMenamin <adrian@...golddream.dyndns.info> To: Andrew Morton <akpm@...ux-foundation.org> Cc: dwmw2@...radead.org, greg@...ah.com, lethal@...ux-sh.org, linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org, linux-mtd@...r.kernel.org Subject: Re: [PATCH] 1/2 Maple: Update bus driver to allow support of VMU device On Thu, 2008-03-20 at 15:39 -0700, Andrew Morton wrote: > On Thu, 20 Mar 2008 22:23:17 +0000 > Adrian McMenamin <adrian@...golddream.dyndns.info> wrote: > > > > > > urgh, down_trylock(). And a secret, undocumented one too. > > > > > > A trylock is always an exceptional thing. How is *any* reader of this code > > > supposed to work out what the heck it's doing there? Convert it into > > > down(), run the code and decrypt the lockdep warnings, I suspect. > > > > > > <looks> > > > > > > Nope, I can't see any other lock being held when we call this function. > > > > > > The trylocks are an utter mystery to me. Please don't write mysterious > > > code. > > > > > > > OK, I am sure this is my problem but I have no idea why you are > > describing down_trylock as undocumented > > I'm describing your use of it! I'm sitting here trying to work out why on > earth this code is using the highly unusual (and highly suspicious) trylock > idiom and this is far from clear. > OK, I understand your point now. Some comments wouldn't go amiss, for sure. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists