linux-kernel - Re: [PATCH 0/4 v4] dma: dma_{un}map_{single|sg}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080320002928.GL1843@sgi.com>
Date:	Wed, 19 Mar 2008 17:29:28 -0700
From:	akepner@....com
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...el.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Jes Sorensen <jes@....com>, Roland Dreier <rdreier@...co.com>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	David Miller <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Grant Grundler <grundler@...isc-linux.org>,
	Michael Ellerman <michael@...erman.id.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4 v4] dma: dma_{un}map_{single|sg}_attrs() interface

On Thu, Mar 13, 2008 at 08:27:54AM -0700, Randy Dunlap wrote:

Thanks for looking at this. A new patchset is on the way.

> On Thu, 13 Mar 2008 01:41:06 -0700 Andrew Morton wrote:
> 
> > > +#ifdef ARCH_USES_DMA_ATTRS
> > 
> > There is no precedent for ARCH_USES_*.
> > 
> > There is a little bit of precedent for ARCH_HAVE_*
> > 
> > There is lots of precendence for ARCH_HAS_*.
> > 
> > We don't like ARCH_HAS_* anyway ;) What can we do to get rid of this? 
> > Ideally, make it available on all architectures at zero cost to those which
> > don't need it.  If that is impractical (why?) then it is preferable to do
> > this in Kconfig.
> 
> Sam has been pushing HAVE_* and even added that to
> Documentation/kbuild/kconfig-language.txt.

OK, changed it to CONFIG_HAVE_DMA_ATTRS.

> 
> > > +/*
> > > + * dma_set_attr - set a specific attribute
> > > + * may be called with a null attrs
> > > + */
> 
> Use kernel-doc notation?

Done.

-- 
Arthur

(503) 234 4671
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/