[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1206058863.16475.165.camel@johannes.berg>
Date: Fri, 21 Mar 2008 01:21:03 +0100
From: Johannes Berg <johannes@...solutions.net>
To: "Rafael J. Wysocki" <rjw@...k.pl>
Cc: pm list <linux-pm@...ts.linux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
Alexey Starikovskiy <astarikovskiy@...e.de>
Subject: Re: [linux-pm] [RFC][PATCH] PM: Introduce new top level suspend
and hibernation callbacks (rev. 2)
> + * All of the above callbacks, except for @complete(), return error codes.
> + * However, the error codes returned by the resume operations, @resume(),
> + * @thaw(), and @restore(), are only printed in the system logs, since the PM
> + * core cannot do anything else about them.
Why bother and not just make them return void, the error printing can
most likely be done much much better in the callback since that possibly
has information on why it failed.
> + * All of the above callbacks, return error codes, but the error codes returned
> + * by the resume operations, @resume_noirq(), @thaw_noirq(), and
> + * @restore_noirq(), are only printed in the system logs, since the PM core
> + * cannot do anything else about them.
Same here, of course.
johannes
Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)
Powered by blists - more mailing lists