linux-kernel - Re: [patch] forcedeth: fix locking bug with netconsole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Mar 2008 12:09:53 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] forcedeth: fix locking bug with netconsole

Ingo Molnar wrote:
> Subject: forcedeth: fix locking bug with netconsole
> From: Ingo Molnar <mingo@...e.hu>
> 
> while using netconsole on forcedeth, lockdep noticed the following
> locking bug:
[...]
> the fix is to disable/restore irqs instead of disable/enable.

So we make _the_ TX fast path slower, to accomodate a path that is 
rarely executed?

That seems like the wrong fix to me.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/