linux-kernel - Re: [PATCH 1/7] LinuxPPS core support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1206118805.24338.7.camel@lov.site>
Date:	Fri, 21 Mar 2008 18:00:05 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Rodolfo Giometti <giometti@...eenne.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: Re: [PATCH 1/7] LinuxPPS core support.

On Fri, 2008-03-21 at 11:56 +0100, Rodolfo Giometti wrote:
> On Fri, Mar 21, 2008 at 04:36:44AM +0100, Kay Sievers wrote:
> > On Thu, Mar 6, 2008 at 1:09 PM, Rodolfo Giometti <giometti@...ux.it> wrote:
> > > This patch adds the kernel side of the PPS support currently named
> > >  "LinuxPPS".
> > 
> > >  diff --git a/drivers/pps/sysfs.c b/drivers/pps/sysfs.c
> > >  new file mode 100644
> > >  index 0000000..c25c91c
> > >  --- /dev/null
> > >  +++ b/drivers/pps/sysfs.c
> > >  @@ -0,0 +1,130 @@
> > 
> > >  +void pps_sysfs_remove_source_entry(struct pps_device *pps)
> > >  +{
> > >  +       /* Delete info files */
> > >  +       sysfs_remove_group(&pps->dev->kobj, &pps_group);
> > >  +}
> > >  +
> > >  +int pps_sysfs_create_source_entry(struct pps_device *pps)
> > >  +{
> > >  +       int ret;
> > >  +
> > >  +       /* Create info files */
> > >  +       ret = sysfs_create_group(&pps->dev->kobj, &pps_group);
> > 
> > Any specific reason you are creating the group by hand, and not assign
> > it to the default group in your class? It would will let the core
> > handle it for you. The device add uevent to userspace will happen
> > before you added the attributes, which is usually not nice.
> 
> No any specific reason... I just supposed it was the-right-think(TM)!
> :)
> 
> Can you please suggest me an URL where I can see how to rework the
> code?

You can assign class->dev_attrs the array of attributes, and the driver
core will create these attributes for all devices that get registered
with that class. See: drivers/base/core.c :: device_add_attrs().

Kay

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/