linux-kernel - Re: [PATCH] [5/7] Readd rdmsrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Mar 2008 18:16:36 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Andi Kleen <andi@...stfloor.org>, andreas.herrmann3@....com,
	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [5/7] Readd rdmsrl_safe

On Fri, Mar 21, 2008 at 06:06:13PM +0100, Thomas Gleixner wrote:
> On Wed, 12 Mar 2008, Andi Kleen wrote:
> > RDMSR for 64bit values with exception handling.
> > 
> > Makes it easier to deal with 64bit valued MSRs. The old 64bit code
> > base had that too as checking_rdmsrl(), but it got dropped somehow. 
> 
> Yup, no users.
> 
> > +#define rdmsrl_safe(msr,p) \
> > +	({ int __err; *(p) = native_read_msr_safe(msr, &__err); __err; })
> > +
> 
> static inline please

Well all of paravirt.h uses macros. I did the same for consistency. If you want 
inlines it would be better to just convert it all in one go (but please only
after this patch was applied)

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/