lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1206064278.26345.108.camel@localhost>
Date:	Thu, 20 Mar 2008 18:51:18 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Christoph Lameter <clameter@....com>, linux-mm@...ck.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Add definitions of USHRT_MAX

On Fri, 2008-03-21 at 09:40 +0800, Zhang, Yanmin wrote:
> Add definitions of USHRT_MAX and others into kernel. ipc uses it and
> slub implementation might also use it.
> +#define USHRT_MAX	((u16)(~0U))
> +#define SHRT_MAX	((s16)(USHRT_MAX>>1))
> +#define SHRT_MIN	(-SHRT_MAX - 1)

Perhaps it's better to use the most common kernel types?
Perhaps U16_MAX, S16_MAX and S16_MIN?

Don't you need to cast SHRT_MIN/S16_MIN too?
#define S16_MIN ((s16)(-SHRT_MAX - 1))

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ