linux-kernel - Re: [PATCH 1/1] IDE: fix ide.h compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 21 Mar 2008 21:10:29 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Jiri Slaby <jirislaby@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH 1/1] IDE: fix ide.h compiler warning

Hello.

Bartlomiej Zolnierkiewicz wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Subject: [PATCH] ide: do complete DMA setup in ->init_dma method (take 2)

> * Make ide_hwif_setup_dma() return an error value.

> * Pass 'const struct ide_port_info *d' instead of 'unsigned long dmabase'
>   to ->init_dma method and make it return an error value.

> * Rename ide_get_or_set_dma_base() to ide_pci_dma_base(),
>   change ordering of its arguments and then export it.

> * Export ide_pci_set_master().

> * Do complete DMA setup inside ->init_dma method and update ->init_dma
>   users accordingly.

> * Sanitize code for DMA setup in ide_init_port().

> v2:
> * Fix for CONFIG_BLK_DEV_IDEDMA_PCI=n configs
>   (from Jiri Slaby <jirislaby@...il.com>):

>   Fix following compiler warning by returning EINVAL:

>   In file included from ANYTHING-INCLUDING-IDE.H:45:
>   include/linux/ide.h: In function ‘ide_hwif_setup_dma’:
>   include/linux/ide.h:1022: warning: no return statement in function returning non-void

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com>

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/