linux-kernel - Re: [PATCH 8/16][BUG] PCI slot: Fix invalid memory access (Not for mainline!)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080321200154.GN17292@ldl.fc.hp.com>
Date:	Fri, 21 Mar 2008 14:01:54 -0600
From:	Alex Chiang <achiang@...com>
To:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
Cc:	Greg KH <gregkh@...e.de>, Gary Hade <garyhade@...ibm.com>,
	Kristen Carlson Accardi <kristen.c.accardi@...el.com>,
	Matthew Wilcox <matthew@....cx>, warthog19@...lescrag.net,
	rick.jones2@...com, linux-kernel@...r.kernel.org,
	linux-pci@...ey.karlin.mff.cuni.cz, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 8/16][BUG] PCI slot: Fix invalid memory access (Not for
	mainline!)

* Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>:
> Fix kernel oops in pci_release_slot() when dbg() is enabled.

Merged, thanks.

/ac

> 
> The dbg() in pci_release_slot() cause a kernel oops (invalid memory
> access) because it accesses slot after it is released. We need to
> access slot before calling kobject_put().
> 
> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
> 
> ---
>  drivers/pci/slot.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: linux-2.6.25-rc6/drivers/pci/slot.c
> ===================================================================
> --- linux-2.6.25-rc6.orig/drivers/pci/slot.c
> +++ linux-2.6.25-rc6/drivers/pci/slot.c
> @@ -191,13 +191,14 @@ EXPORT_SYMBOL_GPL(pci_create_slot);
>  
>  int pci_destroy_slot(struct pci_slot *slot)
>  {
> +	dbg("%s: decreased refcount to %d on %x:%d\n", __func__,
> +	    atomic_read(&slot->kobj.kref.refcount) - 1, slot->bus->number,
> +	    slot->number);
> +
>  	down_write(&pci_bus_sem);
>  	kobject_put(&slot->kobj);
>  	up_write(&pci_bus_sem);
>  
> -	dbg("%s: decreased refcount to %d on %x:%d\n", __func__,
> -	    atomic_read(&slot->kobj.kref.refcount), slot->bus->number,
> -	    slot->number);
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(pci_destroy_slot);
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/