linux-kernel - Re: [PATCH] x86: relocate_kernel - use predefined PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47E41F99.7090904@zytor.com>
Date:	Fri, 21 Mar 2008 13:50:33 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: relocate_kernel - use predefined PAGE_SIZE	instead
 of own alias

Cyrill Gorcunov wrote:
> [H. Peter Anvin - Fri, Mar 21, 2008 at 01:18:13PM -0700]
>> Cyrill Gorcunov wrote:
>>> This patch does clean up relocate_kernel_(32|64).S a bit by getting rid
>>> of local PAGE_ALIGNED macro. We should use well-known PAGE_SIZE instead
>>> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
>> Looks good!
>>
>> 	-hpa
>>
> 
> Thanks Peter for review, btw we have in relocate_kernel_32.S
> 
> 188:	movl	%cr4, %eax
> 189:	andl	$0, %eax
> 190:	movl	%eax, %cr4
> 
> but maybe would be better just replace it with
> 
> 	xorl	%eax, %eax
> 	movl	%eax, %cr4
> 
> or there is some nonobvious reason not to do so?
> 

The only case I can think of would be if the code expects to patch the 
zero, but even then it'd be cantankerous, because gas will optimize that 
zero down to a single byte.

So, no :)

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/