linux-kernel - Re: [SCSI] fix media change events for polled devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47E4208F.20601@garzik.org>
Date:	Fri, 21 Mar 2008 16:54:39 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi@...r.kernel.org
Subject: Re: [SCSI] fix media change events for polled devices

James Bottomley wrote:
> On Fri, 2008-03-21 at 10:31 -0700, Linus Torvalds wrote:
>> On Fri, 21 Mar 2008, Jeff Garzik wrote:
>>> And that is the fix -- initialize supported_events according to sr/sd's needs,
>>> and revert this change (4d1566ed2100d074ccc654e5cf2e44cdea3a01d0) as obviously
>>> broken.
>> Patches, please? I can do the revert, but the patch to supported_events 
>> and the testing, please?
> 
> I tested this and discussed it with Kristen before it went in.  The
> current fix you sucked in with scsi-rc-fixes basically makes the whole
> lot work for 2.6.25 (both AN media change events and traditional polled
> ones).  The thing that doesn't work is the ability to turn off AN events
> from user space, but that feature never worked anyway.

Not true.  Change the perm with chmod...

But furthermore, change 4d1566ed renders the userspace interface 
/inconsistent/ even for the read-only case that we all acknowledge 
_does_ work.

IOW, after your "fix", the userspace interface gives an incorrect 
picture of what events are/are not masked.


If you don't have the time to complete work on

	commit 285e9670d91cdeb6b6693729950339cb45410fdc
	Author: Kay Sievers <kay.sievers@...y.org>
	Date:   Tue Aug 14 14:10:39 2007 +0200

	    [SCSI] sr,sd: send media state change modification events

then revert _that_.

Don't break my patch, just because yours (which came _after_ mine) 
doesn't work.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/