linux-kernel - Re: [SCSI] fix media change events for polled devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Mar 2008 17:13:06 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi@...r.kernel.org
Subject: Re: [SCSI] fix media change events for polled devices

James Bottomley wrote:
> On Fri, 2008-03-21 at 17:04 -0400, Jeff Garzik wrote:
>> James Bottomley wrote:
>>> It's fixed, and nothing else is additionally broken by the current fix.
>> Other than the newly-inconsistent, exported-to-userspace interface, ITYM.
> 
> How is it newly inconsistent?  It can still be used in the manner you
> intended it, namely to tell if the CD supports AN or not.  When we add
> the new bit, we'll have to add a new file for it anyway.

Previously, the events could be expected to be sent (or sent) in strict 
accordance with supported_events.

Now, you are essentially sending out-of-band events, because the 
receiver requested supported_events -- but is getting much more than that!

You broke a fundamental assumption of the interface -- that 
supported_events accurately and fully represented all events sent via 
the new API.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/