linux-kernel - Re: [PATCH 4/5] cdrom: use list_head for cdrom_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080322175752.GA24089@infradead.org>
Date:	Sat, 22 Mar 2008 13:57:52 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] cdrom: use list_head for cdrom_device_info list

On Sun, Mar 23, 2008 at 12:10:45AM +0900, Akinobu Mita wrote:
> 2008/3/22, Jens Axboe <jens.axboe@...cle.com>:
> > On Sat, Mar 22 2008, Akinobu Mita wrote:
> >  > Use list_head for cdrom_device_info list instead of opencoded
> >  > singly list handling.
> >
> >
> > Looks good, but you don't seem to be initializing ->list anywhere. Did
> >  you test this?
> >
> >  I'd suggest just adding an INIT_LIST_HEAD() before the list_add() in
> >  register_cdrom()
> 
> It seems that current list_add() implementation doesn't need
> initalized new entry with/without CONFIG_DEBUG_LIST.

it never did and never should.  only the list head needs to be
initialized.

your patch is fine in that respect.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/