linux-kernel - Re: [PATCH] firewire: wait until PHY configuration packet was transmitted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200803212312.41277.jwilson@redhat.com>
Date:	Fri, 21 Mar 2008 23:12:41 -0400
From:	Jarod Wilson <jwilson@...hat.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: wait until PHY configuration packet was transmitted

On Thursday 20 March 2008 06:48:23 pm Stefan Richter wrote:
> We now exit fw_send_phy_config /after/ the PHY config packet has been
> transmitted, instead of before.  A subsequent fw_core_initiate_bus_reset
> will therefore not overlap with the transmission.  This is meant to make
> the send PHY config packet + reset bus routine more deterministic.
>
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>

Will double-check Monday that this solves never-ending (until panic) bus 
resets with a jmicron controller in the office, but this does indeed prevent 
a very similar looking case with a via vt6307 ohci 1.0 controller + iogear 
hub + unibrain fire-i camera:

  http://bugzilla.kernel.org/show_bug.cgi?id=10128

Wondering if this will be the ticket for nForce2 controllers as well. Still 
trying to track one down to poke at myself, although we can probably find 
someone out there to test. Also wondering how we hold up against a bus reset 
storm initiated by another host, thinking maybe we can still trigger the 
list_add corruption in that bug, but stopping the endless bus reset loops is 
definitely an improvement.

Signed-off-by: Jarod Wilson <jwilson@...hat.com>

-- 
Jarod Wilson
jwilson@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/