[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87od975tgc.fsf@blp.benpfaff.org>
Date: Fri, 21 Mar 2008 20:27:31 -0700
From: Ben Pfaff <blp@...stanford.edu>
To: linux-kernel@...r.kernel.org
Cc: linux-mm@...ck.org
Subject: Re: [patch 2/9] Store max number of objects in the page struct.
Andrew Morton <akpm@...ux-foundation.org> writes:
>> +#define USHRT_MAX ((u16)(~0U))
>> +#define SHRT_MAX ((s16)(USHRT_MAX>>1))
>> +#define SHRT_MIN (-SHRT_MAX - 1)
>
> We have UINT_MAX and ULONG_MAX and ULLONG_MAX. If these were actually
> UNT_MAX, ULNG_MAX and ULLNG_MAX then USHRT_MAX would make sense.
>
> But they aren't, so it doesn't ;)
>
> Please, let's call them USHORT_MAX, SHORT_MAX and SHORT_MIN.
SHRT_MIN, SHRT_MAX, and USHRT_MAX are the spellings used by
<limits.h> required in ISO-conforming C implementations. That
doesn't mean that the kernel has to use those spellings, but it
does mean that those names are widely understood by C
programmers.
--
Ben Pfaff
http://benpfaff.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists