linux-kernel - Re: [PATCH 4/5] cdrom: use list_head for cdrom_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080322125535.GE15355@kernel.dk>
Date:	Sat, 22 Mar 2008 13:55:35 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] cdrom: use list_head for cdrom_device_info list

On Sat, Mar 22 2008, Akinobu Mita wrote:
> Use list_head for cdrom_device_info list instead of opencoded
> singly list handling.

Looks good, but you don't seem to be initializing ->list anywhere. Did
you test this?

I'd suggest just adding an INIT_LIST_HEAD() before the list_add() in
register_cdrom()

You also seem to remove the !cdi check, which would be an unrelated
change.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/