linux-kernel - Re: [PATCH 120/148] include/asm-x86/suspend_32.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 Mar 2008 12:16:08 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Joe Perches <joe@...ches.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 120/148] include/asm-x86/suspend_32.h: checkpatch
	cleanups - formatting only

On Sun, 2008-03-23 at 11:57 +0300, Alexey Dobriyan wrote:
> On Sun, Mar 23, 2008 at 01:03:35AM -0700, Joe Perches wrote:
> > --- a/include/asm-x86/suspend_32.h
> > +++ b/include/asm-x86/suspend_32.h
> > @@ -32,11 +32,11 @@ extern unsigned long saved_edi;
> >  static inline void acpi_save_register_state(unsigned long return_point)
> >  {
> >  	saved_eip = return_point;
> > -	asm volatile ("movl %%esp,%0" : "=m" (saved_esp));
> > -	asm volatile ("movl %%ebp,%0" : "=m" (saved_ebp));
> > -	asm volatile ("movl %%ebx,%0" : "=m" (saved_ebx));
> > -	asm volatile ("movl %%edi,%0" : "=m" (saved_edi));
> > -	asm volatile ("movl %%esi,%0" : "=m" (saved_esi));
> > +	asm volatile("movl %%esp,%0" : "=m" (saved_esp));
> > +	asm volatile("movl %%ebp,%0" : "=m" (saved_ebp));
> > +	asm volatile("movl %%ebx,%0" : "=m" (saved_ebx));
> > +	asm volatile("movl %%edi,%0" : "=m" (saved_edi));
> > +	asm volatile("movl %%esi,%0" : "=m" (saved_esi));
> 
> Since when "volatile" became a function?

Agreed, this is crack.

Joe, please find something useful to contribute. Having a few cleanup
patches at the beginning of a useful series isn't an issue, but such
series as posted here are utterly annoying, and by the above just plain
stupid.

checkpatch.pl is a guide, not a replacement for common sense.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/