linux-kernel - Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080323.051929.267232495.davem@davemloft.net>
Date:	Sun, 23 Mar 2008 05:19:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jirislaby@...il.com
Cc:	viro@...IV.linux.org.uk, joe@...ches.com, mingo@...e.hu,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups
 - formatting only

From: Jiri Slaby <jirislaby@...il.com>
Date: Sun, 23 Mar 2008 13:06:04 +0100

> On 03/23/2008 11:20 AM, David Miller wrote:
> > From: Al Viro <viro@...IV.linux.org.uk>
> > Date: Sun, 23 Mar 2008 08:52:10 +0000
> > 
> >> On Sun, Mar 23, 2008 at 01:03:24AM -0700, Joe Perches wrote:
> >>> Signed-off-by: Joe Perches <joe@...ches.com>
> >> An obvious corollary to this highly inspired series of patches:
> > 
> > Acked-by: David S. Miller <davem@...emloft.net>
> > 
> > I totally agree, checkpatch is just shit.
> 
> I disagree. It's just misuse in this case (like using Lindent on whole tree).

Unlike sparse, this thing encourages the kind of behavior seen here.

And even worse it becomes monkey see monkey do.

There are mountains of more useful stuff to be working on (much of it
automated, but unlike checkpatch work doesn't result in crap) rather
than 148 patches of checkpatch vomit.

Fixing sparse warnings properly fixes real issues, whereas fixing
checkpatch stuff creates garbage 9 times out of 10.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/