linux-kernel - Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Mar 2008 12:57:56 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org, sam@...nborg.org
Subject: Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet)

On Monday 24 March 2008, Randy Dunlap wrote:
> On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote:
> > Signed-off-by: Mike Frysinger <vapier@...too.org>
> > ---
> >  Documentation/DocBook/Makefile |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/Documentation/DocBook/Makefile
> > b/Documentation/DocBook/Makefile index 300e170..f6a4ba3 100644
> > --- a/Documentation/DocBook/Makefile
> > +++ b/Documentation/DocBook/Makefile
> > @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@
> >
> >  ###
> >  # Rule to convert a .c file to inline XML documentation
> > +       gen_xml = :
> > + quiet_gen_xml = echo '  GEN     $@'
> > +silent_gen_xml = :
> >  %.xml: %.c
> > -	@echo '  GEN     $@'
> > +	@$($(quiet)gen_xml)
> >  	@(                            \
> >  	   echo "<programlisting>";   \
> >  	   expand --tabs=8 < $< |     \
> > --
>
> The Makefile changes are good, but the patch description makes it
> appear that Mike was rushed.  How about something like this?

i just copied & pasted the previous commit messages for similar fixes.  your 
longer version sounds fine to me though.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (828 bytes)