linux-kernel - Re: [PATCH 2/6] compcache: block device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cefeab80803241039n829edeexa141089c40a08a57@mail.gmail.com>
Date:	Mon, 24 Mar 2008 23:09:33 +0530
From:	"Nitin Gupta" <nitingupta910@...il.com>
To:	"Mariusz Kozlowski" <m.kozlowski@...land.pl>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/6] compcache: block device - internal defs

On Mon, Mar 24, 2008 at 9:55 PM, Mariusz Kozlowski
<m.kozlowski@...land.pl> wrote:
> Hi Nitin,
>
>
>  >  +#define K(x)   ((x) >> 10)
>  >  +#define KB(x)  ((x) << 10)
>
>  Hm. These look cryptic unless you remember what they do.
>  Could have better names?

I'll give them better names/add comments.

>
>
>  > +#define CC_DEBUG2((fmt,arg...) \
>  > +       printk(KERN_DEBUG C fmt,##arg)
>
>  Unbalanced parenthesis.
>

Corrected. Thanks.

- Nitin

>  Just my 0.05zl.
>
>         Mariusz
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/