linux-kernel - Re: [PATCH] add random irq flag to natsemi network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47E815C2.1050900@garzik.org>
Date:	Mon, 24 Mar 2008 16:57:38 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	James Simmons <jsimmons@...radead.org>
CC:	Linus Torvalds <torvalds@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] add random irq flag to natsemi network driver

James Simmons wrote:
> Please apply this patch. On the embbeded board I work on this is the only
> entropy source we have. 
> 
> diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> index 385f69c..c6553dd 100644
> --- a/drivers/net/natsemi.c
> +++ b/drivers/net/natsemi.c
> @@ -1529,7 +1529,8 @@ static int netdev_open(struct net_device *dev)
>  	/* Reset the chip, just in case. */
>  	natsemi_reset(dev);
>  
> -	i = request_irq(dev->irq, &intr_handler, IRQF_SHARED, dev->name, dev);
> +	i = request_irq(dev->irq, &intr_handler, IRQF_SHARED | IRQF_SAMPLE_RANDOM,
> +				dev->name, dev);

With timed interrupt mitigation and remotely controlled interrupt 
sources, this can be distinctly non-random.

This type of patch is traditionally not applied...

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/