linux-kernel - Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Mar 2008 02:42:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mingo@...e.hu
Cc:	jirislaby@...il.com, viro@...IV.linux.org.uk, joe@...ches.com,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups
 - formatting only

From: Ingo Molnar <mingo@...e.hu>
Date: Tue, 25 Mar 2008 09:44:57 +0100

> * David Miller <davem@...emloft.net> wrote:
> 
> > I strongly disagree still.
> > 
> > Half the warnings I get when I have run checkpatch on things I've 
> > written were crap.
> 
> could you please give me a file name as an example that i could 
> double-check myself? Thanks,

I can't because I pacified it to cut down the review noise
for the patch in question last time it happened.

I can tell you one more example of things I strongly disagree with
that it does, for example, such as telling me how to document
spinlocks in datastructures.

It wants a comment right above the spinlock_t member, but this
totally ignores that perhaps I put a huge comment explaining
the locking semantics elsewhere.

It's a black and white tool in a grey world, it just sucks.  And I'd
be fine with that if people used it as a guide but people, especially
kernel newbies, treat it as gospel and a way to contribe "useful"
patches.  They aren't useful, they're crap.  Fix a bug instead of this
automaton whitespace noise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/