linux-kernel - Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87myoni0gp.fsf@basil.nowhere.org>
Date:	25 Mar 2008 11:04:22 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jack Steiner <steiner@....com>, mingo@...e.hu, tglx@...utronix.de,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions

Christoph Hellwig <hch@...radead.org> writes:

> On Mon, Mar 24, 2008 at 01:21:16PM -0500, Jack Steiner wrote:
> > 
> > Definitions of UV MMRs.
> > Note: this file is auto-generated by hardware design tools.
> 
> Which is still not an excuse for the crap in there.  Please submit a
> proper header with the needed defintions and shift & mask defintions and
> helpers instead of the bitfields.

bitfields are only problematic on portable code, which this isn't.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/