linux-kernel - Re: [RFC 6/8] x86_64: Define the macros and tables for the basic UV infrastructure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ej9zi05c.fsf@basil.nowhere.org>
Date:	25 Mar 2008 11:11:11 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jack Steiner <steiner@....com>
Cc:	mingo@...e.hu, tglx@...utronix.de, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 6/8] x86_64: Define the macros and tables for the basic UV infrastructure.

Jack Steiner <steiner@....com> writes:

> Define the macros and tables for the basic UV infrastructure.
> 
> 
> (NOTE: a work-in-progress. Pieces missing....)

Does the kernel really need all this information? You just want
to address the UV-APIC right? I suspect you could use a much stripped
down file.

> +DECLARE_PER_CPU(struct uv_hub_info_s, __uv_hub_info);
> +#define uv_hub_info 		(&__get_cpu_var(__uv_hub_info))
> +#define uv_cpu_hub_info(cpu)	(&per_cpu(__uv_hub_info, cpu))
> +
> +/* This header file is used in BIOS code that runs in physical mode */

Not sure what physical mode is.

> +#ifdef __BIOS__
> +#define UV_ADDR(x)		((unsigned long *)(x))
> +#else
> +#define UV_ADDR(x)		((unsigned long *)__va(x))
> +#endif

But it it would be cleaner if your BIOS just supplied a suitable __va()
and then you remove these macros.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/