linux-kernel - Re: [PATCH] [4/7] Don't use large pages to map the first 2/4MB of memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080325113123.GL17986@amd.com>
Date:	Tue, 25 Mar 2008 12:31:23 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	andreas.herrmann3@....com, tglx@...utronix.de, mingo@...e.hu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [4/7] Don't use large pages to map the first 2/4MB of memory

On Wed, Mar 12, 2008 at 03:53:30AM +0100, Andi Kleen wrote:
> 
> Intel recommends to not use large pages for the first 1MB 
> of the physical memory because there are fixed size MTRRs there
> which cause splitups in the TLBs.
> 
> On AMD doing so is also a good idea.

This should especially boost performance on 32 bit. Have you numbers for
that?

> The implementation is a little different between 32bit and 64bit.
> On 32bit I just taught the initial page table set up about this
> because it was very simple to do. This also has the advantage
> that the risk of a prefetch ever seeing the page even
> if it only exists for a short time is minimized.
> 
> On 64bit that is not quite possible, so use set_memory_4k() a little
> later (in check_bugs) instead.
> 
> Signed-off-by: Andi Kleen <ak@...e.de>
Acked-by: Joerg Roedel <joerg.roedel@....com>

> ---
>  arch/x86/kernel/bugs_64.c |   12 ++++++++++++
>  arch/x86/mm/init_32.c     |    6 +++++-
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> Index: linux/arch/x86/kernel/bugs_64.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/bugs_64.c
> +++ linux/arch/x86/kernel/bugs_64.c
> @@ -9,6 +9,7 @@
>  #include <asm/bugs.h>
>  #include <asm/processor.h>
>  #include <asm/mtrr.h>
> +#include <asm/cacheflush.h>
>  
>  void __init check_bugs(void)
>  {
> @@ -18,4 +19,15 @@ void __init check_bugs(void)
>  	print_cpu_info(&boot_cpu_data);
>  #endif
>  	alternative_instructions();
> +
> +	/*
> +	 * Make sure the first 2MB area is not mapped by huge pages
> +	 * There are typically fixed size MTRRs in there and overlapping
> +	 * MTRRs into large pages causes slow downs.
> +	 *
> +	 * Right now we don't do that with gbpages because there seems
> +	 * very little benefit for that case.
> +	 */
> +	if (!direct_gbpages)
> +		set_memory_4k((unsigned long)__va(0), 1);
>  }
> Index: linux/arch/x86/mm/init_32.c
> ===================================================================
> --- linux.orig/arch/x86/mm/init_32.c
> +++ linux/arch/x86/mm/init_32.c
> @@ -181,8 +181,13 @@ static void __init kernel_physical_mappi
>  			/*
>  			 * Map with big pages if possible, otherwise
>  			 * create normal page tables:
> +			 *
> +			 * Don't use a large page for the first 2/4MB of memory
> +			 * because there are often fixed size MTRRs in there
> +			 * and overlapping MTRRs into large pages can cause
> +			 * slowdowns.
>  			 */
> -			if (cpu_has_pse) {
> +			if (cpu_has_pse && !(pgd_idx == 0 && pmd_idx == 0)) {
>  				unsigned int addr2;
>  				pgprot_t prot = PAGE_KERNEL_LARGE;
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/