linux-kernel - Re: [linux-pm] [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Mar 2008 14:06:15 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	linux-pm@...ts.linux-foundation.org,
	Johannes Berg <johannes@...solutions.net>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Alexey Starikovskiy <astarikovskiy@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [linux-pm] [RFC][PATCH] PM: Introduce new top level suspend	and hibernation callbacks (rev. 2)

On Tuesday, 25 of March 2008, Oliver Neukum wrote:
> Am Freitag, 21. März 2008 01:21:03 schrieb Johannes Berg:
> > > + * All of the above callbacks, except for @complete(), return error codes.
> > > + * However, the error codes returned by the resume operations, @resume(),
> > > + * @thaw(), and @restore(), are only printed in the system logs, since the PM
> > > + * core cannot do anything else about them.
> > 
> > Why bother and not just make them return void, the error printing can
> > most likely be done much much better in the callback since that possibly
> > has information on why it failed.
> 
> A device that cannot wake up is unusable. Shouldn't the pm core disconnect()
> such a device?

Well, if ->resume() returns an error, the driver already knows there's a
problem and it can act upon that, at least in principle.

However, the PM core probably shouldn't try to resume the children of a failing
device.  Also, if ->resume_noirq() fails, it probably is not a good idea to
call ->resume() and ->complete() for the same device and for it's children.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/