linux-kernel - Re: [PATCH] x86: PAT bug fix for attribute type check after reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080325143326.GC11323@elte.hu>
Date:	Tue, 25 Mar 2008 15:33:26 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Venki Pallipadi <venkatesh.pallipadi@...el.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	suresh.b.siddha@...el.com
Subject: Re: [PATCH] x86: PAT bug fix for attribute type check after
	reserve_memtype


* Venki Pallipadi <venkatesh.pallipadi@...el.com> wrote:

> Bug fixes for reserve_memtype() call in __ioremap and 
> pci_mmap_page_range(). If reserve_memtype returns non-zero, then it is 
> an error and subsequent free is not required. Requested and returned 
> prot value check should be done when reserve_memtype returns success.

thanks, applied.

> +	if (retval) {
> +		printk("reserve_memtype returned %d\n", retval);

that needs a KERN_INFO, and should be labeled "Warning: ...".

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/