linux-kernel - Re: [git pull] vfs patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0803250859330.2775@woody.linux-foundation.org>
Date:	Tue, 25 Mar 2008 09:05:59 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...IV.linux.org.uk>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [git pull] vfs patches



On Tue, 25 Mar 2008, Al Viro wrote:
>
> misc VFS fixes for 2.6.25.  Please pull from
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Pulled.

And looking at the diffs, I see sequences like

	dget(save.dentry);
	mntget(save.mnt);
	...
	path_put(&save);

which looks very strange compared to the natural sequence:

	path_get(&save);
	..
	path_put(&save);

and yes, I realize the code was just moved (and the reason for the mixing 
is that the "path_put()" conversion was done much more aggressively, as 
the ordering matters), but I'm bringing this up in the hope somebody has 
the energy to clean things like up some day...

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/