linux-kernel - Re: [RFC 8/8] x86_64: Support for new UV apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080325180616.GX2170@one.firstfloor.org>
Date:	Tue, 25 Mar 2008 19:06:16 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jack Steiner <steiner@....com>
Cc:	Andi Kleen <andi@...stfloor.org>, mingo@...e.hu,
	tglx@...utronix.de, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 8/8] x86_64: Support for new UV apic

> > This should be probably factored properly (didn't Jeremy have smp_ops 
> > for this some time ago) so that even the default case is a call.
> 
> By factored, do you means something like:
> 	is_uv_legacy_system()
> 	is_us_non_unique_apicid_system()
> 	...
> 
> Or maybe:
> 	is_uv_system_type(x)   # where x is UV_NON_UNIQUE_APIC, etc

No instead of having lots of if (xyz_system) do_xyz_special()
go through smp_ops for the whole thing so that UV would just have a 
special smp_ops that has special implementions or wrappers. 

Oops I see smp_ops are currently only implemented
for 32bit. Ok do it only once smp_ops exist on 64bit too. 

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/