linux-kernel - Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080325200517.GA4446@sgi.com>
Date:	Tue, 25 Mar 2008 15:05:17 -0500
From:	Dean Nelson <dcn@....com>
To:	apw@...dowen.org, rdunlap@...otime.net, jschopp@...tin.ibm.com
Cc:	jes@....com, linux-kernel@...r.kernel.org, tony.luck@...el.com,
	linux-ia64@...r.kernel.org
Subject: Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl

On Tue, Mar 25, 2008 at 02:25:29PM -0500, dcn@....com wrote:
> 
> Addressed issues raised by scripts/checkpatch.pl. Removed unnecessary curly
> braces.  Eliminated uses of volatiles and use of kernel_thread() and
> daemonize().
> 
> Signed-off-by: Dean Nelson <dcn@....com>
> 

Forgot to mention that scripts/checkpatch.pl gave 15 false positives of
the following type against drivers/misc/xp/xp_main.c.

> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #48: FILE: misc/xp/xp_main.c:48:
> +EXPORT_SYMBOL_GPL(xp_remote_memcpy);

The fact is that the EXPORT_SYMBOL(xp_remote_memcpy) does immediately follow
the function/variable as follows.

enum xp_retval (*xp_remote_memcpy) (void *dst, const void *src, size_t len);
EXPORT_SYMBOL_GPL(xp_remote_memcpy);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/