linux-kernel - Re: [PATCH] list_add corruption in slab.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6101e8c40803251427t777b0afdlf9e49e36b193c729@mail.gmail.com>
Date:	Tue, 25 Mar 2008 22:27:25 +0100
From:	"Oliver Pinter" <oliver.pntr@...il.com>
To:	"Pekka Enberg" <penberg@...helsinki.fi>
Cc:	"Daniel Yeisley" <dan.yeisley@...sys.com>,
	linux-kernel@...r.kernel.org, akpm@...l.org,
	"Christoph Lameter" <clameter@....com>, mel@....ul.ie
Subject: Re: [PATCH] list_add corruption in slab.c

Hi Pekka

this patch for 2.6.22?
(http://repo.or.cz/w/linux-2.6.22.y-op.git)

--8<--
        /* 1) create the cache_cache */
        INIT_LIST_HEAD(&cache_chain);
        list_add(&cache_cache.next, &cache_chain);
        cache_cache.colour_off = cache_line_size();
        cache_cache.array[smp_processor_id()] = &initarray_cache.cache;
        cache_cache.nodelists[node] = &initkmem_list3[CACHE_CACHE];
-->8--
from 2.6.22's slab.c

On 3/25/08, Pekka Enberg <penberg@...helsinki.fi> wrote:
> Hi Daniel,
>
> Daniel Yeisley wrote:
> > I actually saw that initkmem_list reference, but didn't change it since
> > my original patch fixed my list corruption.  Anyway, I made the changed
> > and tested it.  The system booted fine.
>
> Yeah, but the second change is needed; otherwise we forget to fix up
> some of the bootstrap caches.
>
>  > Signed-off-by: Dan Yeisley <dan.yeisley@...sys.com>
>
> Reviewed-by: Pekka Enberg <penberg@...helsinki.fi>
>
> Mel, as this change is related to the memoryless node fix that went in
> 2.6.24, any chance you'd give this patch a spin on your machines so we
> can get the fix in 2.6.25 and 2.6.24-stable?
>
> 			Pekka
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


-- 
Thanks,
Oliver