linux-kernel - Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080326093612.GA22847@logfs.org>
Date:	Wed, 26 Mar 2008 10:36:12 +0100
From:	Jörn Engel <joern@...fs.org>
To:	David Miller <davem@...emloft.net>
Cc:	mingo@...e.hu, jirislaby@...il.com, viro@...IV.linux.org.uk,
	joe@...ches.com, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups - formatting only

On Tue, 25 March 2008 16:11:42 -0700, David Miller wrote:
> >                                     errors   lines of code   errors/KLOC
> > drivers/mtd/devices/block2mtd.c         10             490          20.4
> 
> Ingo, this is devolving into a "code I maintain is great, code you
> maintain sucks, checkpatch says so" kind of discussion, please stop.
> 
> You're not making any friends by making your arguments this way.

To be fair, block2mtd does suck, even conceptually.  But that would
digress too far.

Jörn

-- 
Rules of Optimization:
Rule 1: Don't do it.
Rule 2 (for experts only): Don't do it yet.
-- M.A. Jackson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/