linux-kernel - Re: [patch] bkl2mtd: cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080326105724.GC22847@logfs.org>
Date:	Wed, 26 Mar 2008 11:57:25 +0100
From:	Jörn Engel <joern@...fs.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Ingo Molnar <mingo@...e.hu>, David Miller <davem@...emloft.net>,
	jirislaby@...il.com, joe@...ches.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...dowen.org>
Subject: Re: [patch] bkl2mtd: cleanup

On Wed, 26 March 2008 10:48:21 +0000, Al Viro wrote:
> 
> > -static int _block2mtd_write(struct block2mtd_dev *dev, const u_char *buf,
> > -		loff_t to, size_t len, size_t *retlen)
> > +static int
> > +_block2mtd_write(struct block2mtd_dev *dev, const u_char *buf, loff_t to,
> > +		 size_t len, size_t *retlen)
> 
> That's actually worse...  BTW, single-underscore-... for identifiers?  Odd.

Indeed.  Must have been my fault.

> OTOH, you've missed quite a few of my pet peeves, starting with
> u_char in the quoted part...

A large-scale s/u_char/void/ over mtd read and write functions wouldn't
hurt, no doubt.  Currently every other driver contains a cast to
(u_char*) or three for no gain afaics.

Jörn

-- 
Never argue with idiots - first they drag you down to their level,
then they beat you with experience.
-- unknown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/