linux-kernel - Re: ohci : strange looking use of round_jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0803261136590.6324-100000@iolanthe.rowland.org>
Date:	Wed, 26 Mar 2008 11:37:47 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Richard Kennedy <richard@....demon.co.uk>
cc:	dbrownell@...rs.sourceforge.net,
	linux-usb <linux-usb@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: ohci : strange looking use of round_jiffies_relative. possible
 bug ?

On Wed, 26 Mar 2008, Richard Kennedy wrote:

> I was looking at the uses of round_jiffies and noticed that the ohci
> unlink_watchdog_func() calls 
> mod_timer(&ohci->unlink_watchdog, round_jiffies_relative(HZ));
> 
> Which looks a bit strange as it will set the timer to 0 <= t < HZ.
> Reading the comments I think that is really is expecting to setup timer
> to (now + 1s)
> 
> mod_timer(&ohci->unlink_watchdog, round_jiffies(jiffies + HZ));
> 
> If this is not true then perhaps it needs a comment to explain what it
> _is_ trying to do, because it's got me baffled ;)

I'd say it's a bug.  Or rather a pair of bugs, since that mod_timer() 
call appears in two places.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/