linux-kernel - Re: [PATCH 1/1] Blackfin Watchdog Driver: split platform device/driver registering from actual watchdog device/driver registering so we can cleanly load/unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Mar 2008 01:37:36 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	wim@...ana.be, linux-kernel@...r.kernel.org,
	Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH 1/1] Blackfin Watchdog Driver: split platform device/driver registering from actual watchdog device/driver registering so we can cleanly load/unload

On Wed, Mar 26, 2008 at 06:30:01PM -0700, Bryan Wu wrote:
> +#define pr_devinit(fmt, args...) ({ static const __devinitdata char __fmt[] = fmt; printk(__fmt, ## args); })
>  #define pr_init(fmt, args...) ({ static const __initdata char __fmt[] = fmt; printk(__fmt, ## args); })
>  
WTF? You are trying to micro-optimize the string? And you have a printk
that changes behaviour if you have hotplug enabled or not. That's so
utterly bizarre that the rationale must be fascinating.

pr_xxx() also is a protected namespace that belongs in
include/linux/kernel.h, though I can see why you opted to hide these in
your driver rather than post them for general inclusion.

If you are hurting that badly for space, just turn off CONFIG_PRINTK and
move on with life. This is just insane.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/