linux-kernel - Re: [PATCH] x86_64: resize NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.SGI.3.96.1080326134839.7873204Y-100000@fergus.americas.sgi.com>
Date:	Wed, 26 Mar 2008 13:49:10 -0500 (CDT)
From:	Alan Mayer <ajm@....com>
To:	Pavel Machek <pavel@....cz>
Cc:	Alan Mayer <ajm@....com>, torvalds@...ux-foundation.org,
	mingo@...e.hu, linux-kernel list <linux-kernel@...r.kernel.org>,
	Robin Holt <holt@....com>, Jack Steiner <steiner@....com>,
	Russ Anderson <rja@....com>
Subject: Re: [PATCH] x86_64: resize NR_IRQS for large machines


On Wed, 26 Mar 2008, Pavel Machek wrote:

> Hi!
> 
> > Subject: [PATCH] x86_64: resize NR_IRQS for large machines
> > 
> > From: Alan Mayer <ajm@....com>
> > 
> > On machines with very large numbers of cpus, tables that are dimensioned
> > by NR_IRQS get very large, especially the irq_desc table.  They are also
> > very sparsely used.  When the cpu count is > MAX_IO_APICS, use MAX_IO_APICS
> > to set NR_IRQS, otherwise use NR_CPUS.
> > 
> > Signed-off-by: Alan Mayer <ajm@....com>
> > 
> > Reviewed-by: Christoph Lameter <clameter@....com>
> 
> > ===================================================================
> > --- v2.6.25-rc6.orig/include/asm-x86/irq_64.h	2008-03-19 16:52:52.000000000 -0500
> > +++ v2.6.25-rc6/include/asm-x86/irq_64.h	2008-03-20 16:46:51.000000000 -0500
> > @@ -10,6 +10,10 @@
> >   *	<tomsoft@...ormatik.tu-chemnitz.de>
> >   */
> >  
> > +#if !defined(MAX_IO_APICS)
> > +#include <asm/apicdef.h>
> > +#endif
> > +
> 
> This is very ugly. Why not include it unconditionally -- with guard in
> apicdef.h?
> 							Pavel

Okay, I can change that.

		--ajm

> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 

--
Alan J. Mayer
SGI
ajm@....com
WORK: 651-683-3131
HOME: 651-407-0134
--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/