linux-kernel - Re: [RFC][-mm] [1/2] Simple stats for cpu resource controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6599ad830803261200w5c5749fcx6211f06d5d91c1c9@mail.gmail.com>
Date:	Wed, 26 Mar 2008 12:00:45 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	"Balaji Rao" <balajirrao@...il.com>
Cc:	linux-kernel@...r.kernel.org, balbir@...ibm.com,
	containers@...ts.osdl.org, dhaval@...ux.vnet.ibm.com
Subject: Re: [RFC][-mm] [1/2] Simple stats for cpu resource controller

On Wed, Mar 26, 2008 at 11:18 AM, Balaji Rao <balajirrao@...il.com> wrote:
>  +
>  +static s64 cpu_cgroup_read_stat(struct cpu_cgroup_stat *stat,
>  +               enum cpu_cgroup_stat_index idx)
>  +{
>  +       int cpu;
>  +       s64 ret = 0;
>  +       for_each_possible_cpu(cpu)
>  +               ret += stat->cpustat[cpu].count[idx];

On a 32-bit architecture I think this could race with a non-atomic
update that crosses a 32-bit boundary and get a corrupted result.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/