linux-kernel - Re: ISA -> ISA_ (Re: [GIT PATCH] ACPI patches for 2.6.25-rc6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47EAA246.3050707@gmail.com>
Date:	Wed, 26 Mar 2008 22:21:42 +0300
From:	Alexey Starikovskiy <aystarik@...il.com>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	Len Brown <lenb@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	Corentin CHARY <corentincj@...aif.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...ts.linux-foundation.org
Subject: Re: ISA -> ISA_ (Re: [GIT PATCH] ACPI patches for 2.6.25-rc6)

Bjorn Helgaas wrote:
> On Wednesday 26 March 2008 11:24:41 am Alexey Starikovskiy wrote:
>   
>> Bjorn Helgaas wrote:
>>     
>>> I'm curious about how this works.  I disassembled the DSDT from
>>> http://bugzilla.kernel.org/show_bug.cgi?id=4773 (I attached the disassembly
>>> at http://bugzilla.kernel.org/attachment.cgi?id=15448&action=view), and
>>> the _PRT contains "_SB" and "ISA" (no trailing underscores):
>>>
>>>                 Package (0x04)
>>>                 {
>>>                     0x000DFFFF, 
>>>                     0x00, 
>>>                     \_SB.PCI0.ISA.LNKA, 
>>>                     0x00
>>>                 }
>>>
>>> But by the time we get to acpi_pci_irq_add_entry(), we've added the
>>> underscores somewhere (see
>>> http://bugzilla.kernel.org/attachment.cgi?id=15423&action=view):
>>>
>>>   0000:00:0d[A] -> \_SB_.PCI0.ISA_.LNKA
>>>
>>> I don't know where this happens, but it certainly confused me, and
>>> it seems like it could lead to other bugs.
>>>   
>>>       
>> ACPI is supposed to add trailing underscore for pad all names to 4 bytes.
>> So ISA will be padded to ISA_.
>>     
>
> The questions are "where does this happen?" and "why does it not
> apply to other things like asus_acpi.c?"
>   
1. drivers/acpi/namespace/nsutils.c:419
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/