linux-kernel - Re: [TRIVIAL PATCH] Microcode: show results on success too plus fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080326134053.c75656dc.randy.dunlap@oracle.com>
Date:	Wed, 26 Mar 2008 13:40:53 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"Ben Castricum" <lk08@...castricum.nl>
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [TRIVIAL PATCH] Microcode: show results on success too plus fix
 typo

On Wed, 26 Mar 2008 21:22:25 +0100 Ben Castricum wrote:

> Show a bit more info when updating microcode. It used to be there but 
> no with DEBUG unset makes it very silent.
> 
> This is my first patch, please let me know if I did anything wrong.
> 
> Signed-off-by: Ben Castricum <lk08@...castricum.nl>
> 
> diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
> index f2702d0..ca1fd52 100644
> --- a/arch/x86/kernel/microcode.c
> +++ b/arch/x86/kernel/microcode.c
> @@ -336,11 +336,11 @@ static void apply_microcode(int cpu)
> 
>   spin_unlock_irqrestore(&microcode_update_lock, flags);
>   if (val[1] != uci->mc->hdr.rev) {
> -  printk(KERN_ERR "microcode: CPU%d updated from revision "
> +  printk(KERN_ERR "microcode: CPU%d update from revision "
>     "0x%x to 0x%x failed\n", cpu_num, uci->rev, val[1]);
>    return;
>   }
> - pr_debug("microcode: CPU%d updated from revision "
> + printk(KERN_INFO "microcode: CPU%d updated from revision "
>          "0x%x to 0x%x, date = %08x \n",
>          cpu_num, uci->rev, val[1], uci->mc->hdr.date);
>   uci->rev = val[1];

Your mailer client (*cough*) converted tabs to spaces,
so the patch does not apply cleanly now.
You'll need to find a way to send patches that does not mangle
whitespace.


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/