linux-kernel - Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0803261344430.2775@woody.linux-foundation.org>
Date:	Wed, 26 Mar 2008 13:46:33 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Gary Hade <garyhade@...ibm.com>
cc:	Ingo Molnar <mingo@...e.hu>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Thomas Meyer <thomas@...3r.de>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	pm@...ian.org
Subject: Re: [patch] pci: revert "PCI: remove transparent bridge sizing"



On Wed, 26 Mar 2008, Gary Hade wrote:
> 
> Could be but without the sizing removal I doubt that the fix I
> was going to propose (see below) would be the same.  What I had
> found is that the removal of the transparent bridge sizing was
> leaving the resource record for at least region 7 (IO) of a
> hot-added transparent bridge on the docking station in a state
> that was not palatable with later executed code in pdev_sort_resource().

Ahh, ok, so it was directly caused by simply not sizing and setting up the 
bus resources properly.

> Even though the restoration of the transparent bridge sizing
> corrects the problem, pdev_sort_resource() could probably use
> some bulletproofing.  I will take a look at this.

Thanks,

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/