linux-kernel - Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080326212958.GB27594@elte.hu>
Date:	Wed, 26 Mar 2008 22:29:59 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Gary Hade <garyhade@...ibm.com>
Cc:	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Meyer <thomas@...3r.de>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	pm@...ian.org
Subject: Re: [patch] pci: revert "PCI: remove transparent bridge sizing"


* Gary Hade <garyhade@...ibm.com> wrote:

> On Wed, Mar 26, 2008 at 02:54:58PM +0100, Ingo Molnar wrote:
> > 
> > * Ivan Kokshaysky <ink@...assic.park.msu.ru> wrote:
> > 
> > > Thomas, can you put CONFIG_RESOURCES_64BIT=y back and either revert 
> > > commit 8fa5913d54f3b1e09948e6a0db34da887e05ff1f, or just comment out 
> > > these two lines in drivers/pci/setup-bus.c:
> > > 
> > > 		if (bus->self->transparent)
> > > 			break;
> > > 
> > > and check if it helps?
> > 
> > alternatively, try x86.git/latest which has the revert below included.
> 
> As the author of the "PCI: remove transparent bridge sizing" change, I 
> apologize for the trouble it seems to have caused. [...]

no need to apologize, bugs happen. Could we perhaps add a WARN_ON() 
somewhere to detect the nonsensical (for that particular hardware) 
resource setup?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/