linux-kernel - Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1206568675.6926.7.camel@pasglop>
Date:	Thu, 27 Mar 2008 08:57:55 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Gary Hade <garyhade@...ibm.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Meyer <thomas@...3r.de>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>, pm@...ian.org
Subject: Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

> NOTE! This will also consider a bridge resource at 0 to be an invalid 
> resource (since now the alignment will be zero), which is a bit odd and 
> makes me worry a bit. I wouldn't be surprised if some non-PC architectures 
> have PCI bridges at zero. But maybe they should be (or already are?) 
> marked IORESOURCE_PCI_FIXED?

PCI bridges at zero is perfectly valid indeed and I'm sure we have that
around at least for IO space. In fact, I'm surprised you don't have that
on x86. Typically, things like an HT segment with a P2P bridge and
behind that bridge an ISA bridge could well have the P2P bridge with a
resource forwarding 0...0x1000 IO downstream for example even on x86
no ? (I'm not -that- familiar with the crazyness of legacy ISA on x86
but I've definitely seen such setup on other archs).

For MMIO, it mostly depends whether the code gets to work on raw bus
values, in which case 0 will be around, or already fixed up values (ie,
translated in CPU bus space) in which case 0 is unlikely.

In the case of pdev_sort_resources(), it will manipulate already fixed
up resources, so MMIO should work, but I'm a bit worried by PIO.

Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/