linux-kernel - Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1206575149.6926.57.camel@pasglop>
Date:	Thu, 27 Mar 2008 10:45:49 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Ivan Kokshaysky <ink@...assic.park.msu.ru>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Gary Hade <garyhade@...ibm.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Meyer <thomas@...3r.de>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>, pm@...ian.org
Subject: Re: [patch] pci: revert "PCI: remove transparent bridge sizing"


On Thu, 2008-03-27 at 02:29 +0300, Ivan Kokshaysky wrote:

> Well, at this point (pdev_sort_resources call) bridge resource->start
> has nothing to do with a bus address, it just a temporary storage for
> required alignment, filled by sizing routines (and 0 is definitely
> invalid here).

Allright, that sounds better then.

>  I know, this is quite confusing, but I didn't want to add extra
> fields to existing structures or create temporary per-bus trees...
> But after pci_assign_resource() that resource can certainly be at 0,
> depending on PCIBIOS_MIN_{IO,MEM} and free slots in the resource tree.

In fact, this is the resource assignment code, and PCIBIOS_MIN_* is set
to non-0 for powerpc too so we don't try to assign things down at 0
anyway, so we don't have a problem. We only care about things at 0 that
have already been put there by the firmware and that we decide not to
reassign.

So I don't have any objection anymore.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/