linux-kernel - Re: [PATCH 1/3] Clocklib: add generic framework for managing clocks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080327091810.GA32396@flint.arm.linux.org.uk>
Date:	Thu, 27 Mar 2008 09:18:10 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Cc:	Dmitry <dbaryshkov@...il.com>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, hskinnemoen@...el.com,
	domen.puncer@...argo.com, lethal@...ux-sh.org, tony@...mide.com,
	paul@...an.com
Subject: Re: [PATCH 1/3] Clocklib: add generic framework for managing clocks.

On Thu, Mar 27, 2008 at 10:06:23AM +0100, Haavard Skinnemoen wrote:
> > +	int		users;
> 
> Reference counting, probably need that too.
> 
> > +	unsigned long	rate;
> 
> This one is redundant. Use getrate() instead.

... which means a separate getrate() functions for every clock.  Not really
practical for PXA.

> > +	int		delay;
> 
> Huh? A delay after enabling the clock? Why can't the enable() hook do
> that if it's really necessary?

... which means a separate enable() function for each clock.  The delay
there has not a lot to do with the actual register you're frobbing, but
the resy of the SoC.  So, again, not really practical for PXA.

The result for PXA is a tradeoff between reducing the data size and
increasing the text size, or increasing the data size and keeping
the existing data size.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/