linux-kernel - Re: [PATCH -mm 1/4] x86_64 boot: Add free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080327120850.GC6589@basil.nowhere.org>
Date:	Thu, 27 Mar 2008 13:08:50 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Paul Jackson <pj@....com>, "Huang, Ying" <ying.huang@...el.com>,
	hpa@...or.com, andi@...stfloor.org, mingo@...hat.com,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 1/4] x86_64 boot: Add free_early to early reservation machanism

On Thu, Mar 27, 2008 at 12:58:51PM +0100, Ingo Molnar wrote:
> 
> * Paul Jackson <pj@....com> wrote:
> 
> > Huang wrote:
> > > +		panic("free_early on not reserved area: %lx-%lx!", start, end);
> > 
> > Should that be 'early_panic', not 'panic' ?
> > 
> > (I see a couple more panics in that file, which I wonder
> > if should be early_panic as well ?)
> 
> this should be fixed properly btw: panic() should self-select whether it 
> does an early_panic() or a real panic().

There's also need of a EARLY_BUG, but self selection would be a little
tricky here.

I still have an old patch for this, but I haven't gotten around to submit it
because it turned out the first user of it wasn't a good idea.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/