linux-kernel - Re: sparc64 BUG: using smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080326.233354.102892522.davem@davemloft.net>
Date:	Wed, 26 Mar 2008 23:33:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	m.kozlowski@...land.pl, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org
Subject: Re: sparc64 BUG: using smp_processor_id() in preemptible

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Wed, 26 Mar 2008 20:25:02 -0700

> On Wed, 26 Mar 2008 04:25:16 -0700 (PDT) David Miller <davem@...emloft.net> wrote:
> 
> >  	preempt_disable();
> >  
> > +	mp = &__get_cpu_var(mmu_gathers);
> 
> that's an open-coded get_cpu_var().
> 
> fwiw.  Which isn't much, IMO.  Sometimes it's nice to see things open-coded.

Good point, I might restructure that to use {get,put}_cpu_var().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/