linux-kernel - Re: [PATCH 5/7] omfs: add bitmap routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6c5339f0803280626p221872b6t15f9b6fc9bc480f3@mail.gmail.com>
Date:	Fri, 28 Mar 2008 09:26:19 -0400
From:	"Bob Copeland" <me@...copeland.com>
To:	"Arnd Bergmann" <arnd@...db.de>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 5/7] omfs: add bitmap routines

On Thu, Mar 27, 2008 at 11:51 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Thursday 27 March 2008, Bob Copeland wrote:
>
>  > +static int nibblemap[] = {4, 3, 3, 2, 3, 2, 2, 1, 3, 2, 2, 1, 2, 1, 1, 0};
>  > +
>  > +unsigned long omfs_count_free(struct super_block *sb)
>
>  I think it would be helpful to express this using hweight64.

Thanks for the review.

Yes, that would probably be cleaner.  FWIW minix and affs both have
this sort of code too.

-Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/