linux-kernel - Re: [patch 09/10] Hugetlb common code update for System z.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080328140634.GA29218@elte.hu>
Date:	Fri, 28 Mar 2008 15:06:34 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Gerald Schaefer <gerald.schaefer@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, haveblue@...ibm.com,
	schwidefsky@...ibm.com, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Tony Luck <tony.luck@...el.com>,
	Paul Mackerras <paulus@...ba.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [patch 09/10] Hugetlb common code update for System z.


* Gerald Schaefer <gerald.schaefer@...ibm.com> wrote:

>  include/asm-sh/hugetlb.h      |   28 +++++++++++++++++++++++++
>  include/asm-sparc64/hugetlb.h |   30 +++++++++++++++++++++++++++
>  include/asm-x86/hugetlb.h     |   28 +++++++++++++++++++++++++

these seem largely duplicated - shouldnt there be an 
asm-generic/hugetlb.h instead, which asm/hugetlb.h could include to get 
default behavior? It would probably reduce the linecount of your patch 
as well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/