linux-kernel - Re: agpgart: when telling user you'll corrupt his data, at least do it at KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080328142529.GU29105@one.firstfloor.org>
Date:	Fri, 28 Mar 2008 15:25:29 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Pavel Machek <pavel@....cz>, Andi Kleen <andi@...stfloor.org>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: agpgart: when telling user you'll corrupt his data, at least do it at KERN_CRIT

> yes that is the theory - but how did your disk get corrupted in 
> practice? ;-)

I suspect after wakeup due to the wrong ordering in resume (agp resume function
called too late).

The IOMMU code unfortunately doesn't know that the GART has gone away. 

The right fix for that is probably to move the GART resume code into
some shared file and make it a sysdev.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/